Repository navigation
lead: render bounded status and ask cards from typed facts - #685
Conversation
3f109be to
9042b63
Compare
|
O-372 readiness update: Milestone B is after v0.2.1, tracked in v0.2.2; review and approval preparation may continue, merging is deferred. #685 and #764 already carry the v0.2.2 milestone. This supersedes the earlier body sentence deferring all review capacity; it does not lift the merge hold or O-367's separate prohibition on pre-release A2A draft review/rebuild. Current-source/dependency check: main Smallest next scope remains this card boundary: review deterministic typed status/ask rendering, fresh-read callback per supported command, bounded/escaped output, missing/stale/future/corrupt unknown states, revision-zero unavailable, and separation of local acceptance/publication/landing. No mutation route or private task-state reader belongs in it. Once the facts/runner public APIs land, merge current main normally into this own branch, adapt lead-owned fixtures to the published type, add the already-prepared public-API composition coverage, and run the hosted current-head gate before claiming ready. Do not copy unmerged facts/task-state implementation or revive old runner-failure claims without fresh evidence. Fresh T2 review of the card-boundary slice is requested under O-372. Merge remains later. #764/#776 stay separate drafts; A2A carry/drop remains on #629 under O-367. No source change, build/test, new CI, approval or merge performed for this readiness update. |
|
O-372 preparation: normal merge of current main fd076b3 into this own branch produced 35b7105, without conflicts or force-push. Diff against main remains exactly cards.rs, lead/mod.rs, lib.rs module registration and lead_cards.rs; no facts/task-state implementation copied. Lead-file rustfmt and whitespace checks pass. Pushing starts fresh hosted checks; no local builds/tests. Draft remains for public-API composition dependency; review is now of 35b7105, earlier CI/verdicts are historical. Merge deferred to v0.2.2 under O-372; O-367 intact. |
|
Coordinator confirmed #685 scope: typed-card composition uses public Source check at #684 Prepared only lead-owned source/tests in a separate detached scratch checkout of exact #684: current card renderer, Running.step fixture adaptation to the published type, existing public append/situation composition fixture (running/local acceptance/block/ask; close ask advances next read; merge independently advances landed), and a missing Facts::open fixture showing both commands return unknown without initializing storage. Setup uses synthetic Facts::initialize/append; command reads use public APIs only. No task state/log parsing or private facts files. Formatting/whitespace checks pass; this current preparation is NOT compiled/tested qualification. It remains unpublished scratch until the API lands; no unmerged library implementation or conditional/ignored composition test is added to #685. Current #685 head35b7105 hosted lane remains independently observed. Draft/merge-later boundaries and O-367 remain. |
|
Current-main preparation qualified: head35b710541ea97ce2ab6095ecce7a54e2d65ecab3 lane44041301873 SUCCESS on hosted x86_64 and ARM64; draft checks44041310086 SUCCESS. Original singleton interval120 observer exited0; no unchanged rerun, local builds/tests or force-push. Still draft: current #684 public-API composition fixtures are prepared but not integrated/tested until that library lands. Fresh review requested on this exact head; O-372 merge-later retained. |
|
O411 REFRESH executed atde2e89a0: normal merge of main346cc036, no rebase. Own diff remains323 added lines, zero source deletions; renderer and synthetic tests are byte-identical to35b71054. Main native/goal/other lane changes preserved. Consume typed Snapshot from the public situation read; no copied facts, private logs or parallel task state. This is a renderer library only; live wiring remains separate. Fresh automatic hosted CI is required; no repeated unchanged full review or local builds/tests. |
|
O418 handoff: helper is now sole writer. Exact published headde2e89a0b6b9f96202a95a88d010f18e3460737b; worktree clean, no unpublished edits. This main-only merge predates O420; renderer/tests unchanged,323 own added lines/zero deletions. Lane44078816978 observer exited0; no live watcher. Required44078825921 needs one later terminal read. Preserve head under O420, consume public typed facts API, no copied facts/log parsing or repeat unchanged review. I retain949/carry coordination only. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de2e89a0b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
First-pass review by oxa → oxc → Codex findingsCONFIRMED — P2, 🤖 Generated with Claude Code (oxa review lane) |
|
First-pass review by oxa → oxc → Codex findings
TIER: T2 🤖 Generated with Claude Code (oxa review lane) |
|
First-pass review by oxa → oxc → Codex findings
No additional concrete defects found. 🤖 Generated with Claude Code (oxa review lane) |
|
Corrected-head qualification: 3f193e9 passed hosted lane 44112519863 and required checks 44112535443. The synthetic directional-mark regression failed before the fix in 44110600407. Automatic Cloud code summary 6951240034 names this exact corrected commit with has_any_findings=false and has_unresolved_findings=false. Security review completed, but nullable outcome fields are not a clean-security claim. This normal renderer slice has no live command entry point; public Facts storage composition and live wiring remain separate. Head preserved; no local build/test, merge or queue request. |
|
Resolved a newly confirmed GitHub CONFLICTING state by a normal merge of main ed7ec35, now head 1351039. The sole conflict was lib.rs adjacent module registration: retained both this PR lead and main lead_page. Renderer and tests are byte-identical to clean reviewed 3f193e9; own diff remains four files, 342 additions, zero removals. No fresh full review requested for unchanged source. New-head CI must qualify; prior green runs are historical, not current-head clearance. Default CLI activation remains unchanged; no local builds/tests. |
|
Actual GitHub main conflict resolved by normal merge at71ae802f00f86f511fdf6e2fa0ec648f2489a042. The conflict was only the adjacent lib.rs module declarations; main lead_access/lead_input/page/panels/peer and this PR lead module coexist. Card/mod/test source blobs are unchanged from1351039e. The own added/removed lines are identical: zero-context stable patch-id74d03d44a8e7b1688321d3f9cd3bd4f7aefeb2e5 before and after. Hosted lane44153043823 and required checks44153052983 are running. No renderer rewrite, live observer wiring, new feature, local build/test or repeated review request. Preserve prior qualification for the unchanged own patch; current integrated CI remains necessary. |
Main's typed situation fact now carries `Running::step`, so the lead card fixtures no longer compiled: `Running` was still built with the previous field set, which broke the oxa-cli test target and the all-targets clippy job. Add the field with an in-progress step; no assertion changes. Fold the control/bidi glyph check into one helper as well, so every line stays inside the workspace rustfmt width. The escaped set is unchanged.
|
Restored the previously prepared public-storage composition fixture at |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
T2. Implements the typed
/statusand/askscard renderer for #629. The existing orchestrator track is coordinated in #1017; the earlier after-release hold is superseded.Each supported command obtains a fresh
Result<Snapshot, E>through its callback. Unknown or mutation commands never invoke the reader. Cards bound output to 12 physical lines, retain source sequence/time and standing revision, distinguish local acceptance/publication/landing, and report missing decision metadata as unavailable. Storage errors remain opaque. This PR adds no live CLI/TUI entry point or mutation authority.The renderer consumes the public typed observation rather than copying facts storage, task state or log parsing.
Facts::situationfrom #684 is the intended storage-side callback. #684 is on main. The carried integration fixture now exercises the public read callback against a file-backed Facts store. Live observer/runner wiring remains a separate slice.Current head:
1351039e158f858082d282af81f01c0b40bd4566, a normal main merge resolving the real adjacent lead/lead_page module conflict. Renderer and tests are unchanged from reviewed3f193e9b435bb76fac4ee60371eb5976de8cdab7. The latest Cloud finding identified three Unicode directional format marks that bypassed escaping. The added synthetic goal/ask regression failed on hosted lane 44110600407 at test-first headc5170cbd33c45f3930c0cd6f210bab32b8a55236; the follow-up changes one match arm to escape all three. Pre-refresh corrected-head lane 44112519863 passed on hosted x86_64 and ARM64; required checks 44112535443 passed. Exact-head Cloud code summary 6951240034 reports no findings or unresolved findings. Security review completed with nullable outcome fields; no clean-security outcome is inferred from those fields. Current merge-head checks 44115434188 and lane 44115419944 passed; Cloud code summary 6951240034 names exact head1351039e with no findings. Rust CodeQL analysis is still in progress; no overall landing clearance is claimed. All earlier CI is historical evidence only.Validation: direct Rust formatting and whitespace checks; all builds/tests run in hosted CI, with no real credentials or provider calls. No local builds/tests. Automatic Cloud review remains required.
Removes: no existing source or behavior. Adds renderer registration and synthetic regression coverage; no facts/task-state implementation, live command enablement or new orchestration framework.
Current head
efba8da2551c3b84663aab8c8b1f9698f95d2526merges both typedRunning.stepfixture commits and retains the already-published fixture and equivalent Unicode escaping refactor. The resulting tree is identical to the previous remote head. Hosted lane 44162423463 passed on this head.Ports the situation and asks presentation of #307 row digest + attn-watch (port plan). The renderer consumes bounded typed facts. Wake delivery and alarm generation are separate.
Current integration head
b877b8a942971e02b88eec4aa7f10cf313225f48passed hosted lane 44168117795 on x86_64 and ARM64. The hosted log confirms both file-backedlead_storagetests ran. The draft gate passed in 44168128760. Ready for full required checks and a review of this head.